FFL-2510: Add allocationKey to ResolutionDetails and thread to OpenFeature metadata#3570
Draft
typotter wants to merge 3 commits into
Draft
FFL-2510: Add allocationKey to ResolutionDetails and thread to OpenFeature metadata#3570typotter wants to merge 3 commits into
typotter wants to merge 3 commits into
Conversation
…ad to OF flagMetadata
Remove dead extractMetadata (duplicate of buildMetadata, no callers). In toEvaluationMetadata, iterate flagMetadata first then write allocationKey last so typed field always wins over any flagMetadata "allocationKey" entry. Add combined allocationKey+flagMetadata test and collision test to ConvertersTest.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3570 +/- ##
===========================================
+ Coverage 72.53% 72.55% +0.02%
===========================================
Files 978 978
Lines 36058 36060 +2
Branches 6041 6042 +1
===========================================
+ Hits 26152 26162 +10
+ Misses 8234 8232 -2
+ Partials 1672 1666 -6
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
allocationKeyas a top-level field onResolutionDetailsand threads it into OpenFeatureProviderEvaluationmetadata under the key"allocationKey"when non-null. ExistingflagMetadata/extraLoggingfields preserved for backwards compatibility.Motivation
FFL-2510 — promotes
allocationKeyto a top-level field on our ownResolutionDetailsstruct, making it directly accessible without digging into metadata maps.Additional Notes
N/A
Review checklist (to be filled by reviewers)